From d0fff5147b1590838c616f81200fa5cbaf6021d6 Mon Sep 17 00:00:00 2001 From: Mathieu Velten Date: Thu, 22 Sep 2022 11:51:20 +0200 Subject: [PATCH] Dockerfile for tests: align comments with current behavior Signed-off-by: Mathieu Velten --- changelog.d/13867.misc | 1 + docker/complement/Dockerfile | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 changelog.d/13867.misc diff --git a/changelog.d/13867.misc b/changelog.d/13867.misc new file mode 100644 index 000000000000..bb48c77dbb5c --- /dev/null +++ b/changelog.d/13867.misc @@ -0,0 +1 @@ +Align comments with current behavior for the Docker build used for testing purpose. diff --git a/docker/complement/Dockerfile b/docker/complement/Dockerfile index 0e13722d1c00..b69abac8b5f4 100644 --- a/docker/complement/Dockerfile +++ b/docker/complement/Dockerfile @@ -8,16 +8,16 @@ ARG SYNAPSE_VERSION=latest -# first of all, we create a base image with a postgres server and database, -# which we can copy into the target image. For repeated rebuilds, this is -# much faster than apt installing postgres each time. +# First of all, we copy postgres server from the official postgres image, +# since for repeated rebuilds, this is much faster than apt installing +# postgres each time. # # This trick only works because (a) the Synapse image happens to have all the # shared libraries that postgres wants, (b) we use a postgres image based on # the same debian version as Synapse's docker image (so the versions of the # shared libraries match). -# now build the final image, based on the Synapse image. +# We also initialize the database itself at build and not runtime for speed reason. FROM matrixdotorg/synapse-workers:$SYNAPSE_VERSION # copy the postgres installation over from the image we built above