Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit c9a2b5d

Browse files
authored
More robust handling of the Content-Type header for thumbnail generation (#9788)
Signed-off-by: Sergey Shpikin <rkfg@rkfg.me>
1 parent 4b965c8 commit c9a2b5d

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

changelog.d/9788.bugfix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix thumbnail generation for some sites with non-standard content types. Contributed by @rkfg.

synapse/config/repository.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ def parse_thumbnail_requirements(thumbnail_sizes):
7070
jpeg_thumbnail = ThumbnailRequirement(width, height, method, "image/jpeg")
7171
png_thumbnail = ThumbnailRequirement(width, height, method, "image/png")
7272
requirements.setdefault("image/jpeg", []).append(jpeg_thumbnail)
73+
requirements.setdefault("image/jpg", []).append(jpeg_thumbnail)
7374
requirements.setdefault("image/webp", []).append(jpeg_thumbnail)
7475
requirements.setdefault("image/gif", []).append(png_thumbnail)
7576
requirements.setdefault("image/png", []).append(png_thumbnail)

synapse/rest/media/v1/media_repository.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -467,6 +467,9 @@ async def _download_remote_file(
467467
return media_info
468468

469469
def _get_thumbnail_requirements(self, media_type):
470+
scpos = media_type.find(";")
471+
if scpos > 0:
472+
media_type = media_type[:scpos]
470473
return self.thumbnail_requirements.get(media_type, ())
471474

472475
def _generate_thumbnail(

0 commit comments

Comments
 (0)