Fix getTurnServer response: integer ttl

lukaslihotzki · lukaslihotzki · commit 9802de23cec0 · 2021-09-27T12:18:16.000+02:00
`ttl` must be an integer according to the OpenAPI spec: https://github.com/matrix-org/matrix-doc/blob/old_master/data/api/client-server/voip.yaml#L70 True division (`/`) returns a float instead (`"ttl": 7200.0`). Floor division (`//`) returns an integer, so the response is spec compliant. Signed-off-by: Lukas Lihotzki <lukas@lihotzki.de>
diff --git a/changelog.d/10922.bugfix b/changelog.d/10922.bugfix
@@ -0,0 +1 @@
+Fix a minor bug in the response to `/_matrix/client/r0/voip/turnServer`. Contributed by @lukaslihotzki.
diff --git a/synapse/rest/client/voip.py b/synapse/rest/client/voip.py
@@ -70,7 +70,7 @@ async def on_GET(self, request: SynapseRequest) -> Tuple[int, JsonDict]:
             {
                 "username": username,
                 "password": password,
-                "ttl": userLifetime / 1000,
+                "ttl": userLifetime // 1000,
                 "uris": turnUris,
             },
         )

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix a minor bug in the response to `/_matrix/client/r0/voip/turnServer`. Contributed by @lukaslihotzki.
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ async def on_GET(self, request: SynapseRequest) -> Tuple[int, JsonDict]:`
`70`	`70`	`{`
`71`	`71`	`"username": username,`
`72`	`72`	`"password": password,`
`73`		`- "ttl": userLifetime / 1000,`
	`73`	`+ "ttl": userLifetime // 1000,`
`74`	`74`	`"uris": turnUris,`
`75`	`75`	`},`
`76`	`76`	`)`