Add annotation which would have caught #12410

David Robertson · David Robertson · commit 85a808606fe0 · 2022-04-07T17:58:24.000+01:00
Can't use `args: QueryParams` here because QueryParams is a Mapping,
which is immutable.
diff --git a/synapse/federation/transport/client.py b/synapse/federation/transport/client.py
@@ -504,7 +504,7 @@ async def get_public_rooms(
         else:
             path = _create_v1_path("/publicRooms")
 
-            args: Dict[str, Any] = {
+            args: Dict[str, Union[str, Iterable[str]]] = {
                 "include_all_networks": "true" if include_all_networks else "false"
             }
             if third_party_instance_id:

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ async def get_public_rooms(`
`504`	`504`	`else:`
`505`	`505`	`path = _create_v1_path("/publicRooms")`
`506`	`506`
`507`		`- args: Dict[str, Any] = {`
	`507`	`+ args: Dict[str, Union[str, Iterable[str]]] = {`
`508`	`508`	`"include_all_networks": "true" if include_all_networks else "false"`
`509`	`509`	`}`
`510`	`510`	`if third_party_instance_id:`