Add an experimental config option.

Author: clokep

rust/src/push/mod.rs

@@ -417,6 +417,7 @@ pub struct FilteredPushRules {
     enabled_map: BTreeMap<String, bool>,
     msc3664_enabled: bool,
     msc1767_enabled: bool,
+    msc3952_intentional_mentions: bool,
 }
 
 #[pymethods]
@@ -427,12 +428,14 @@ impl FilteredPushRules {
         enabled_map: BTreeMap<String, bool>,
         msc3664_enabled: bool,
         msc1767_enabled: bool,
+        msc3952_intentional_mentions: bool,
     ) -> Self {
         Self {
             push_rules,
             enabled_map,
             msc3664_enabled,
             msc1767_enabled,
+            msc3952_intentional_mentions,
         }
     }
 
@@ -461,6 +464,11 @@ impl FilteredPushRules {
                     return false;
                 }
 
+                if !self.msc3952_intentional_mentions && rule.rule_id.contains("org.matrix.msc3952")
+                {
+                    return false;
+                }
+
                 true
             })
             .map(|r| {

stubs/synapse/synapse_rust/push.pyi

@@ -45,6 +45,7 @@ class FilteredPushRules:
         enabled_map: Dict[str, bool],
         msc3664_enabled: bool,
         msc1767_enabled: bool,
+        msc3952_intentional_mentions: bool,
     ): ...
     def rules(self) -> Collection[Tuple[PushRule, bool]]: ...
 

synapse/config/experimental.py

@@ -142,3 +142,8 @@ def read_config(self, config: JsonDict, **kwargs: Any) -> None:
 
         # MSC3925: do not replace events with their edits
         self.msc3925_inhibit_edit = experimental.get("msc3925_inhibit_edit", False)
+
+        # MSC3952: Intentional mentions
+        self.msc3952_intentional_mentions = experimental.get(
+            "msc3952_intentional_mentions", False
+        )

synapse/storage/databases/main/push_rule.py

@@ -88,6 +88,7 @@ def _load_rules(
         enabled_map,
         msc3664_enabled=experimental_config.msc3664_enabled,
         msc1767_enabled=experimental_config.msc1767_enabled,
+        msc3952_intentional_mentions=experimental_config.msc3952_intentional_mentions,
     )
 
     return filtered_rules

tests/push/test_bulk_push_rule_evaluator.py

@@ -128,6 +128,7 @@ def test_action_for_event_by_user_disabled_by_config(self) -> None:
         self.get_success(bulk_evaluator.action_for_events_by_user([(event, context)]))
         bulk_evaluator._action_for_event_by_user.assert_not_called()
 
+    @override_config({"experimental_features": {"msc3952_intentional_mentions": True}})
     def test_mentions(self) -> None:
         """Test the behavior of an event which includes invalid mentions."""
         bulk_evaluator = BulkPushRuleEvaluator(self.hs)