Bump jsonschema stubs (#12912)

matrix-org · May 30, 2022 · 796a031 · 796a031
1 parent 6be4953
commit 796a031
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/changelog.d/12912.misc b/changelog.d/12912.misc
@@ -0,0 +1 @@
+Bump types-jsonschema from 4.4.1 to 4.4.6.
diff --git a/poetry.lock b/poetry.lock
diff --git a/synapse/events/validator.py b/synapse/events/validator.py
@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 import collections.abc
-from typing import Iterable, Type, Union
+from typing import Iterable, Type, Union, cast
 
 import jsonschema
 
@@ -103,7 +103,12 @@ def validate_new(self, event: EventBase, config: HomeServerConfig) -> None:
             except jsonschema.ValidationError as e:
                 if e.path:
                     # example: "users_default": '0' is not of type 'integer'
-                    message = '"' + e.path[-1] + '": ' + e.message  # noqa: B306
+                    # cast safety: path entries can be integers, if we fail to validate
+                    # items in an array. However the POWER_LEVELS_SCHEMA doesn't expect
+                    # to see any arrays.
+                    message = (
+                        '"' + cast(str, e.path[-1]) + '": ' + e.message  # noqa: B306
+                    )
                     # jsonschema.ValidationError.message is a valid attribute
                 else:
                     # example: '0' is not of type 'integer'