Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 73403d5

Browse files
authored
Fix inconsistencies between MSC3952 and implementation. (#14957)
* Correct the push rule IDs. * Removes the sound tweak for room notifications.
1 parent 41d177c commit 73403d5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

changelog.d/14957.feature

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Experimental support for [MSC3952](https://github.com/matrix-org/matrix-spec-proposals/pull/3952): intentional mentions.

rust/src/push/base_rules.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ pub const BASE_APPEND_OVERRIDE_RULES: &[PushRule] = &[
132132
default_enabled: true,
133133
},
134134
PushRule {
135-
rule_id: Cow::Borrowed(".org.matrix.msc3952.is_user_mentioned"),
135+
rule_id: Cow::Borrowed(".org.matrix.msc3952.is_user_mention"),
136136
priority_class: 5,
137137
conditions: Cow::Borrowed(&[Condition::Known(KnownCondition::IsUserMention)]),
138138
actions: Cow::Borrowed(&[Action::Notify, HIGHLIGHT_ACTION, SOUND_ACTION]),
@@ -148,15 +148,15 @@ pub const BASE_APPEND_OVERRIDE_RULES: &[PushRule] = &[
148148
default_enabled: true,
149149
},
150150
PushRule {
151-
rule_id: Cow::Borrowed(".org.matrix.msc3952.is_room_mentioned"),
151+
rule_id: Cow::Borrowed(".org.matrix.msc3952.is_room_mention"),
152152
priority_class: 5,
153153
conditions: Cow::Borrowed(&[
154154
Condition::Known(KnownCondition::IsRoomMention),
155155
Condition::Known(KnownCondition::SenderNotificationPermission {
156156
key: Cow::Borrowed("room"),
157157
}),
158158
]),
159-
actions: Cow::Borrowed(&[Action::Notify, HIGHLIGHT_ACTION, SOUND_ACTION]),
159+
actions: Cow::Borrowed(&[Action::Notify, HIGHLIGHT_ACTION]),
160160
default: true,
161161
default_enabled: true,
162162
},

0 commit comments

Comments
 (0)