Fix the 'set_device_id_for_pushers_txn' background update. (#15391)

sandhose · web-flow · commit 6eb3edec4738 · 2023-04-05T07:49:15.000-04:00
Refer to the correct field from the response when updating
the background update progress.
diff --git a/changelog.d/15391.bugfix b/changelog.d/15391.bugfix
@@ -0,0 +1 @@
+Fix the `set_device_id_for_pushers_txn` background update crash.
diff --git a/synapse/storage/databases/main/pusher.py b/synapse/storage/databases/main/pusher.py
@@ -562,7 +562,7 @@ def set_device_id_for_pushers_txn(txn: LoggingTransaction) -> int:
             )
 
             self.db_pool.updates._background_update_progress_txn(
-                txn, "set_device_id_for_pushers", {"pusher_id": rows[-1]["id"]}
+                txn, "set_device_id_for_pushers", {"pusher_id": rows[-1]["pusher_id"]}
             )
 
             return len(rows)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix the `set_device_id_for_pushers_txn` background update crash.
Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,7 @@ def set_device_id_for_pushers_txn(txn: LoggingTransaction) -> int:`
`562`	`562`	`)`
`563`	`563`
`564`	`564`	`self.db_pool.updates._background_update_progress_txn(`
`565`		`- txn, "set_device_id_for_pushers", {"pusher_id": rows[-1]["id"]}`
	`565`	`+ txn, "set_device_id_for_pushers", {"pusher_id": rows[-1]["pusher_id"]}`
`566`	`566`	`)`
`567`	`567`
`568`	`568`	`return len(rows)`