Only remove event if it was in the result in the first place.

Author: richvdh

synapse/handlers/federation.py

@@ -1017,14 +1017,17 @@ async def get_state_ids_for_pdu(self, room_id: str, event_id: str) -> List[str]:
 
         state_map = next(iter(state_groups.values()))
 
-        if event.is_state():
-            # Get previous state
+        # we need the state *before* event.
+        state_key = event.get_state_key()
+        if (
+            state_key is not None
+            and state_map.get((event.type, state_key)) == event.event_id
+        ):
             if "replaces_state" in event.unsigned:
                 prev_id = event.unsigned["replaces_state"]
-                if prev_id != event.event_id:
-                    state_map[(event.type, event.state_key)] = prev_id
+                state_map[(event.type, state_key)] = prev_id
             else:
-                state_map.pop((event.type, event.state_key), None)
+                del state_map[(event.type, state_key)]
 
         return list(state_map.values())