Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 52bfa2d

Browse files
authored
Update contributing.md to warn against rebasing an open PR. (#10563)
Signed-off-by: H.Shay <shaysquared@gmail.com>
1 parent b5de77c commit 52bfa2d

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,7 @@ To prepare a Pull Request, please:
252252
4. on GitHub, [create the Pull Request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request);
253253
5. add a [changelog entry](#changelog) and push it to your Pull Request;
254254
6. for most contributors, that's all - however, if you are a member of the organization `matrix-org`, on GitHub, please request a review from `matrix.org / Synapse Core`.
255+
7. if you need to update your PR, please avoid rebasing and just add new commits to your branch.
255256

256257

257258
## Changelog

changelog.d/10563.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Update contributing.md to warn against rebasing an open PR.

0 commit comments

Comments
 (0)