Add comma missing from #15382. (#15429)

reivilibre · web-flow · commit 38272be03710 · 2023-04-13T15:06:25.000+01:00
* Add missing comma

* Newsfile

Signed-off-by: Olivier Wilkinson (reivilibre) &lt;oliverw@matrix.org&gt;

---------

Signed-off-by: Olivier Wilkinson (reivilibre) &lt;oliverw@matrix.org&gt;
diff --git a/changelog.d/15429.misc b/changelog.d/15429.misc
@@ -0,0 +1 @@
+Improve DB performance of clearing out old data from `stream_ordering_to_exterm`.
diff --git a/synapse/storage/databases/main/event_federation.py b/synapse/storage/databases/main/event_federation.py
@@ -1708,7 +1708,7 @@ def _delete_old_forward_extrem_cache_txn(txn: LoggingTransaction) -> None:
                 WHERE stream_ordering < ?
             """
             txn.execute(
-                sql, (self.stream_ordering_month_ago)  # type: ignore[attr-defined]
+                sql, (self.stream_ordering_month_ago,)  # type: ignore[attr-defined]
             )
 
         await self.db_pool.runInteraction(

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Improve DB performance of clearing out old data from `stream_ordering_to_exterm`.
Original file line number	Diff line number	Diff line change
`@@ -1708,7 +1708,7 @@ def _delete_old_forward_extrem_cache_txn(txn: LoggingTransaction) -> None:`
`1708`	`1708`	`WHERE stream_ordering < ?`
`1709`	`1709`	`"""`
`1710`	`1710`	`txn.execute(`
`1711`		`- sql, (self.stream_ordering_month_ago) # type: ignore[attr-defined]`
	`1711`	`+ sql, (self.stream_ordering_month_ago,) # type: ignore[attr-defined]`
`1712`	`1712`	`)`
`1713`	`1713`
`1714`	`1714`	`await self.db_pool.runInteraction(`