Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 20189a7

Browse files
committed
TODO(faster joins -> TODO(faster_joins
1 parent a998a36 commit 20189a7

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

synapse/handlers/device.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -996,7 +996,7 @@ async def incoming_device_list_update(
996996
# Check if we are partially joining any rooms. If so we need to store
997997
# all device list updates so that we can handle them correctly once we
998998
# know who is in the room.
999-
# TODO(faster joins): this fetches and processes a bunch of data that we don't
999+
# TODO(faster_joins): this fetches and processes a bunch of data that we don't
10001000
# use. Could be replaced by a tighter query e.g.
10011001
# SELECT EXISTS(SELECT 1 FROM partial_state_rooms)
10021002
partial_rooms = await self.store.get_partial_state_room_resync_info()

synapse/replication/tcp/streams/partial_state.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def __init__(self, hs: "HomeServer"):
4242
store = hs.get_datastores().main
4343
super().__init__(
4444
hs.get_instance_name(),
45-
# TODO(faster joins, multiple writers): we need to account for instance names
45+
# TODO(faster_joins, multiple writers): we need to account for instance names
4646
current_token_without_instance(store.get_un_partial_stated_rooms_token),
4747
store.get_un_partial_stated_rooms_from_stream,
4848
)

synapse/storage/databases/main/room.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ def __init__(
132132
("un_partial_stated_room_stream", "instance_name", "stream_id")
133133
],
134134
sequence_name="un_partial_stated_room_stream_sequence",
135-
# TODO(faster joins, multiple writers) Support multiple writers.
135+
# TODO(faster_joins, multiple writers) Support multiple writers.
136136
writers=["master"],
137137
)
138138
else:
@@ -1274,7 +1274,7 @@ async def get_join_event_id_and_device_lists_stream_id_for_partial_state(
12741274
return result["join_event_id"], result["device_lists_stream_id"]
12751275

12761276
def get_un_partial_stated_rooms_token(self) -> int:
1277-
# TODO(faster joins, multiple writers): This is inappropriate if there
1277+
# TODO(faster_joins, multiple writers): This is inappropriate if there
12781278
# are multiple writers because workers that don't write often will
12791279
# hold all readers up.
12801280
# (See `MultiWriterIdGenerator.get_persisted_upto_position` for an

0 commit comments

Comments
 (0)