Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 10595c8

Browse files
author
Sean Quah
committed
Fix insufficient mocking in test
1 parent 17dd441 commit 10595c8

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tests/handlers/test_e2e_keys.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -891,14 +891,20 @@ def test_query_all_devices_caches_result(self, device_ids: Iterable[str]) -> Non
891891
new_callable=mock.MagicMock,
892892
return_value=make_awaitable(["some_room_id"]),
893893
)
894+
mock_get_users = mock.patch.object(
895+
self.store,
896+
"get_users_server_still_shares_room_with",
897+
new_callable=mock.MagicMock,
898+
return_value=make_awaitable({remote_user_id}),
899+
)
894900
mock_request = mock.patch.object(
895901
self.hs.get_federation_client(),
896902
"query_user_devices",
897903
new_callable=mock.MagicMock,
898904
return_value=make_awaitable(response_body),
899905
)
900906

901-
with mock_get_rooms, mock_request as mocked_federation_request:
907+
with mock_get_rooms, mock_get_users, mock_request as mocked_federation_request:
902908
# Make the first query and sanity check it succeeds.
903909
response_1 = self.get_success(
904910
e2e_handler.query_devices(

0 commit comments

Comments
 (0)