Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Commit 0eb9b2f

Browse files
clokeperikjohnston
authored andcommitted
Fix installing pysaml2 on Python 3.5. (#8898)
This pins pysaml2 to < 6.4.0 on Python 3.5, as the last known working version.
1 parent 3ce2f30 commit 0eb9b2f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

changelog.d/8898.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add a maximum version for pysaml2 on Python 3.5.

synapse/python_dependencies.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,11 @@
9999
# python 3.5.2, as per https://github.com/itamarst/eliot/issues/418
100100
'eliot<1.8.0;python_version<"3.5.3"',
101101
],
102-
"saml2": ["pysaml2>=4.5.0"],
102+
"saml2": [
103+
# pysaml2 6.4.0 is incompatible with Python 3.5 (see https://github.com/IdentityPython/pysaml2/issues/749)
104+
"pysaml2>=4.5.0,<6.4.0;python_version<'3.6'",
105+
"pysaml2>=4.5.0;python_version>='3.6'",
106+
],
103107
"oidc": ["authlib>=0.14.0"],
104108
"systemd": ["systemd-python>=231"],
105109
"url_preview": ["lxml>=3.5.0"],

0 commit comments

Comments
 (0)