Fix TypeError: 'dict_keys' object is not reversible (#14280)

erikjohnston · web-flow · commit 09b588854e3a · 2022-10-24T13:05:14.000+01:00
diff --git a/changelog.d/14280.bugfix b/changelog.d/14280.bugfix
@@ -0,0 +1 @@
+Fix broken outbound federation when using Python 3.7. Broke in v1.70.0rc1.
diff --git a/synapse/federation/sender/__init__.py b/synapse/federation/sender/__init__.py
@@ -536,8 +536,7 @@ async def handle_room_events(events: List[EventBase]) -> None:
 
                 if event_entries:
                     now = self.clock.time_msec()
-                    last_id = next(reversed(event_ids))
-                    ts = event_to_received_ts[last_id]
+                    ts = max(t for t in event_to_received_ts.values() if t)
                     assert ts is not None
 
                     synapse.metrics.event_processing_lag.labels(

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix broken outbound federation when using Python 3.7. Broke in v1.70.0rc1.`