Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support being provided an access token without first having logged in #14

Open
turt2live opened this issue May 11, 2019 · 4 comments
Open

Comments

@turt2live
Copy link
Member

Many bots work by being provided an access token and aren't aware of their password - pantalaimon should support this by making a /account/whois call on tokens it does not recognize.

@poljar
Copy link
Collaborator

poljar commented May 21, 2019

For this to work reliably we would need to know the device ID of the access token as well. If, for example, someone provides an access token of a device that already has encryption keys uploaded we shouldn't create new device keys and refuse to work with such an access token (provided that we don't have a pan client running for this user).

We can only create new device keys for access tokens that don't have device keys uploaded.

To get an user ID from an access token we can use the /account/whoami call.

The mentioned /account/whois call already requires the user ID and doesn't seem to return a device ID at all.

A list of devices can be fetched with the /devices call. But that returns the full list of devices and there isn't an easy and reliable way to figure out which device belongs to this access token.

Am I missing something with the /account/whois call that would make this possible?

@turt2live
Copy link
Member Author

The endpoint could certainly use an extension to expose this information

@poljar poljar closed this as completed in 3d87b46 May 24, 2019
@poljar
Copy link
Collaborator

poljar commented May 24, 2019

This has only been partially fixed.

@poljar poljar reopened this May 24, 2019
@turt2live
Copy link
Member Author

Have opened MSC2033 to try and address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants