Copy deep link when using Element client #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying the link helps clients to retrieve the room the user originally tried to reach if they are going through the signup flow
t3chguy
reviewed
Nov 28, 2022
15 tasks
|
this would have closed element-hq/element-meta#248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the first bullet point in the alternative solutions of #263
Will be a first step to help with element-hq/element-web#22821
What does this do?
Uses the "clipboard hack" to add the URL of the room the user tries to join. This helps restore the client to the correct state after the user goes through the signup flow.
It also make sure the "Continue" button does not dissapear from under your feet after being clicked on mobile