Skip to content

Conversation

tulir
Copy link
Member

@tulir tulir commented May 9, 2023

@turt2live
Copy link
Member

@tulir is this meant to be ready for review?

@turt2live turt2live added the release-blocker Blocks the next release from happening label May 16, 2023
@tulir
Copy link
Member Author

tulir commented May 16, 2023

Very likely needs some improvements, but yeah I guess most of the important content is there so it can be looked at

@tulir tulir marked this pull request as ready for review May 16, 2023 09:09
@tulir tulir requested a review from a team as a code owner May 16, 2023 09:09
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of little things, but generally looks really good. Thanks for doing this!

@turt2live turt2live removed their request for review May 19, 2023 03:17
@turt2live turt2live requested a review from anoadragon453 May 23, 2023 15:17
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for tackling all the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker Blocks the next release from happening
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants