Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify sha1 representation in state resolution sort #706

Open
achan1989 opened this issue Oct 20, 2020 · 0 comments
Open

Clarify sha1 representation in state resolution sort #706

achan1989 opened this issue Oct 20, 2020 · 0 comments
Labels
A-Room-spec Something to do with the room version specifications clarification An area where the expected behaviour is understood, but the spec could do with being more explicit

Comments

@achan1989
Copy link

The room version 1 spec says of state resolution:

Sort the list by ascending depth then descending sha1(event_id)

We should clarify if it matters what sha1 representation we are using in our comparison. A lexicographic sort of the hash as a hex string or a decimal string, a numeric sort an integer, as a memcmp of bytes, etc. Presumably the goal is to achieve a stable ordering of events in the DAG, but does the ordering have to be consistent across all servers?
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@turt2live turt2live added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit A-Room-spec Something to do with the room version specifications labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-spec Something to do with the room version specifications clarification An area where the expected behaviour is understood, but the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @achan1989