Thumbnail method isn't required and has no default

[Sorunome]

Either it has to be required or a default has to be specified

[richvdh]

please could you clarify the context here?

[Sorunome]

In the specification for media thumbnails it says that the field method is an enum, one of crop or scale. It, however, does not specify that that field is required. And it also doesn't specify a default. So, what should happen if it is not set? Use crop? Use scale? Display a fluffy fox?

As reference, synapse seems to default to scale.

[richvdh]

Either it has to be required or a default has to be specified

or a third option: it's up to the server.

[Sorunome]

or a third option: it's up to the server.

That is undefined behaviour, causing different servers to behave differently, causing very unexpected results. That is a bad option :/

[richvdh]

if, as a client, you care which you get, why not just specify?

[richvdh]

I mean: I don't disagree that it would probably be nice to make it mandatory; I'm just failing to see that it is a major problem.

[Sorunome]

if, as a client, you care which you get, why not just specify?

Currently riot-web doesn't specify for <img> tags

I mean: I don't disagree that it would probably be nice to make it mandatory; I'm just failing to see that it is a major problem.

Undefined behaviour always sounds like a problem. Some person will depend on synapse using scale, and then everything breaks if they use another server

[richvdh]

Some person will depend on synapse using scale, and then everything breaks if they use another server

fair point.