Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reason of redactions is in clear-text even for E2EE messages #1608

Open
davidegirardi opened this issue Jul 31, 2023 · 2 comments
Open
Labels
A-E2EE Issues about end-to-end encryption wart A point where the protocol is inconsistent or inelegant

Comments

@davidegirardi
Copy link
Contributor

Redactions are clear-text events and they can contain an optional reason, also in clear text. This can lead at a partial content leak if a user writes something related to the ongoing discussion in the reason of a redaction of a message in an E2EE room.

Suggestion
Handle the context of m.room.redaction as m.room.encrypted so there's no clear-text information except the needed details of the reaction event. This is probably in conflict with the move of redacts into content by MSC2174.

Workaround
Explicitly tell to the client developers to inform their users that redaction reasons are in clear-text.

@davidegirardi davidegirardi added the improvement An idea/future MSC for the spec label Jul 31, 2023
@turt2live turt2live added wart A point where the protocol is inconsistent or inelegant A-E2EE Issues about end-to-end encryption and removed improvement An idea/future MSC for the spec labels Jul 31, 2023
@jplatte
Copy link
Contributor

jplatte commented Oct 24, 2023

Is this really in conflict w/ MSC2174 (which landed with room v11)? We already have m.room.encrypted events with m.relates_to existing next to the encrypted payload, I don't see what would prevent redactions from getting the same treatment for the redacts field.

@davidegirardi
Copy link
Contributor Author

Because the homeserver has to to copy the redacts property from inside content to outside of it and needs to make sure they are the same.

We already have m.room.encrypted events with m.relates_to existing next to the encrypted payload, I don't see what would prevent redactions from getting the same treatment for the redacts field.

I think this is what I was trying to say with:

Suggestion Handle the context of m.room.redaction as m.room.encrypted so there's no clear-text information except the needed details of the reaction event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE Issues about end-to-end encryption wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Development

No branches or pull requests

3 participants