Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit mentions within code blocks should not trigger ping #15

Closed
HarHarLinks opened this issue Feb 2, 2022 · 0 comments · Fixed by matrix-org/matrix-spec-proposals#3952
Closed

Explicit mentions within code blocks should not trigger ping #15

HarHarLinks opened this issue Feb 2, 2022 · 0 comments · Fixed by matrix-org/matrix-spec-proposals#3952
Labels
A-Push enhancement A suggestion for a relatively simple improvement to the protocol

Comments

@HarHarLinks
Copy link
Contributor

Suggestion
I think it is reasonable to assume that if I write @HarHarLinks or @room inside a code block, then that should not be interpreted as ping/explicit mention. See how GitHub does not linkify them either.

Meanwhile, my preliminary opinion is that pizza should probably still trigger my pizza keyword, but that would be up to discussion.
@HarHarLinks HarHarLinks added the enhancement A suggestion for a relatively simple improvement to the protocol label Feb 2, 2022
@richvdh richvdh added the A-Push label Feb 2, 2022
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@clokep clokep mentioned this issue Dec 23, 2022
Closed
2 tasks
@clokep clokep mentioned this issue Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Push enhancement A suggestion for a relatively simple improvement to the protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSC3952: Intentional Mentions matrix-org/matrix-spec-proposals
2 participants
@richvdh @HarHarLinks