Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The event size limit lives in the Client-Server API docs #1208

Open
anoadragon453 opened this issue Aug 11, 2022 · 4 comments
Open

The event size limit lives in the Client-Server API docs #1208

anoadragon453 opened this issue Aug 11, 2022 · 4 comments
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit wart A point where the protocol is inconsistent or inelegant

Comments

@anoadragon453
Copy link
Member

Currently it lives in the Client-Server API, but will likely be tied to a room version if changed. Thus it should live in the room version definitions.
@anoadragon453 anoadragon453 changed the title Move the documentation for event size limits to the room version spec The event size limit lives in the Client-Server API docs Aug 11, 2022
@anoadragon453
Copy link
Member Author

@turt2live says that we should only do this once it differs between room versions, otherwise it will cause confusion.

@richvdh
Copy link
Member

richvdh commented Aug 11, 2022

Yeah, I take the point, but the problem with it not being in the room versions doc is that I'm not sure where it should be. It's not really specific to either the C-S API or the S-S API. It really lives alongside the "Event format" imho.

@turt2live
Copy link
Member

It would live in the appendices if we didn't have room versions, so there seems like a reasonable home if we don't plan on making room version-needed changes to the size.

@richvdh
Copy link
Member

richvdh commented Aug 11, 2022

I guess that's fair, provided we link to it from other places.

@turt2live turt2live added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit wart A point where the protocol is inconsistent or inelegant labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @anoadragon453 @richvdh