Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POST /_matrix/client/v3/rooms/{roomId}/leave does not cover all possible error situations #1181

Open
Half-Shot opened this issue Jul 22, 2022 · 0 comments
Open

POST /_matrix/client/v3/rooms/{roomId}/leave does not cover all possible error situations #1181

Half-Shot opened this issue Jul 22, 2022 · 0 comments
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit wart A point where the protocol is inconsistent or inelegant

Comments

@Half-Shot
Copy link
Contributor

https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3roomsroomidleave

The spec covers the success state and the ratelimited state, but it does not cover leaving a room that you are not part of. I suspect that like the invite and join endpoints, it should no-op if you're effectively trying to leave->leave, but Synapse will only do this sometimes.

This was brought up in the context of matrix-org/matrix-spec-proposals#3848.
@turt2live turt2live added clarification An area where the expected behaviour is understood, but the spec could do with being more explicit wart A point where the protocol is inconsistent or inelegant labels Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification An area where the expected behaviour is understood, but the spec could do with being more explicit wart A point where the protocol is inconsistent or inelegant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @Half-Shot