Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2249: Require users to have visibility on an event when submitting reports #2249

Merged
merged 7 commits into from
May 7, 2023
Merged

MSC2249: Require users to have visibility on an event when submitting reports #2249

merged 7 commits into from
May 7, 2023

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Aug 27, 2019 •
edited by turt2live
Loading

@Half-Shot Half-Shot added the proposal A matrix spec change proposal label Aug 27, 2019
@turt2live
Copy link
Member

it's not in review if it's a WIP.

@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
@turt2live turt2live marked this pull request as draft April 8, 2021 23:36
@Half-Shot Half-Shot changed the title [WIP] MSC2249: Require users to have visibility on an event when submitting reports MSC2249: Require users to have visibility on an event when submitting reports Apr 29, 2021
@Half-Shot Half-Shot marked this pull request as ready for review April 29, 2021 15:31
@Half-Shot
Copy link
Contributor Author

This is no longer in WIP

erkinalp
erkinalp suggested changes Apr 29, 2021
View reviewed changes
proposals/2249-report-require-joined.md Outdated Show resolved Hide resolved
Half-Shot and others added 2 commits May 3, 2021 21:54
@Half-Shot
Remove proposal
06faec6
@Half-Shot @uhoreg
add "with"
35d7813 
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
@turt2live turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Mar 3, 2023
@turt2live
Copy link
Member

Given synapse has accidentally implemented this MSC, and it makes sense, we should just accept it.

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Mar 3, 2023 •
edited by anoadragon453
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Mar 3, 2023
@turt2live turt2live self-assigned this Mar 3, 2023
@mscbot
Copy link
Collaborator

mscbot commented May 2, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 2, 2023
@mscbot
Copy link
Collaborator

mscbot commented May 7, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels May 7, 2023
@turt2live turt2live merged commit 8a7a944 into old_master May 7, 2023
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels May 7, 2023
turt2live added a commit that referenced this pull request May 8, 2023
@Half-Shot @uhoreg @turt2live
MSC2249: Require users to have visibility on an event when submitting…
126ca85 
… reports (#2249)

* Add MSC2247

* 2247 -> 2249

* Fill out MSC some more

* Remove proposal

* add "with"

Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>

* Update MSC to M_NOT_FOUND

---------

Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
Co-authored-by: Travis Ralston <travisr@matrix.org>
@Half-Shot Half-Shot mentioned this pull request May 9, 2023
Merged
@Half-Shot
Copy link
Contributor Author

Spec PR

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 9, 2023
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Aug 15, 2023
@zecakeh zecakeh mentioned this pull request Aug 21, 2023
Closed
28 tasks
@clokep clokep mentioned this pull request Aug 23, 2023
Closed
4 tasks
@S7evinK S7evinK mentioned this pull request Oct 2, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erkinalp erkinalp erkinalp requested changes

@turt2live turt2live turt2live left review comments

@uhoreg uhoreg uhoreg left review comments

Assignees

@Half-Shot Half-Shot

Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Spec Core Team Backlog
Status: Done to some definition
[Temp] SCT MSC intake board
Status: Done for now
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/reportEvent should require you to be in the room?
6 participants
@Half-Shot @turt2live @mscbot @uhoreg @erkinalp @anoadragon453