Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push notification rules should not resolve the matrix host as a username or display name keyword #2735

Closed
wvffle opened this issue Aug 18, 2020 · 5 comments

Comments

@wvffle
Copy link

wvffle commented Aug 18, 2020

Push notification rules should not resolve the matrix host as a username or display name keyword. In case where you have an username which is the same as the host and any other user on the same host is replied, you'll be notified of this.

Example: If matrix tag is @juniorjpdj:juniorjpdj.pl and when message of @somebody:juniorjpdj.pl is replied to, @juniorjpdj:juniorjpdj.pl will get the notification due to the host being the same as the username.

Same goes with the display name. If the display name is for example: wvffle though the username is @waff:wvffle.net and @somebody:wvffle.net is replied to, @waff:wvffle.net will get a push notification.

I still want to receive the notifications just fine when someone actually pings me, so disabling push notifications for display name or username is not what will resolve my issue.

This is related to element-hq/element-web#14943

@JuniorJPDJ
Copy link

JuniorJPDJ commented Aug 18, 2020

I think it should resolve matrix host as username, but this should be skipped especially in tags.
When I talk about tags I mean something like this: <a href='https://matrix.to/#/@juniorjpdj:juniorjpdj.pl'>@juniorjpdj</a>
Tags should be treated like a whole thing - and if whole tag doesn't match user it shouldn't make him notified.

@turt2live
Copy link
Member

This is configurable with push rules.

@JuniorJPDJ
Copy link

JuniorJPDJ commented Aug 18, 2020

This isn't really configurable, as at example I'd like to be notified for @JuniorJPDJ and for @telegram_USER_ID:juniorjpdj.pl not and I can't find good enough rule to get both. As far as I understand it's also true for @wvffle.
Think about how annoying is it in conjunction with matrix-org/matrix-spec#680 when someone replies to someone else's message on puppeted channel in conversation and I'm getting randomly notified.

@turt2live
Copy link
Member

Turn off notifications for your username, change your display name so it doesn't match, and set up an extra keyword rule to match against @yourname so it doesn't pull the domain part.

In general, using your preferred display name as a domain is discouraged for this reason. It's not only a problem for unexpected mentions, but permalinks too. For permalinks it's nearly impossible to tell if the mention was intentional or not.

@t3chguy
Copy link
Member

t3chguy commented Aug 18, 2020

I think it should resolve matrix host as username, but this should be skipped especially in tags.

Push rules never see the tags as they run against the body not the formatted_body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants