Skip to content

Conversation

@poljar
Copy link
Contributor

@poljar poljar commented Oct 31, 2025

This closes #5816.

  • Public API changes documented in changelogs (optional)

@poljar poljar requested a review from a team as a code owner October 31, 2025 13:20
@poljar poljar requested review from Hywan and removed request for a team October 31, 2025 13:20
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that my approval counts for much, but thank you! 🙏

@poljar poljar force-pushed the poljar/catch-22-token-refresh branch from c5a8f87 to e5d7434 Compare October 31, 2025 13:51
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! It's clear and tested, all good.

@poljar poljar force-pushed the poljar/catch-22-token-refresh branch from e5d7434 to 23d2b5b Compare October 31, 2025 13:58
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 31, 2025

CodSpeed Performance Report

Merging #5822 will not alter performance

Comparing poljar/catch-22-token-refresh (23d2b5b) with main (ee82861)

Summary

✅ 50 untouched

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 88.67925% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.51%. Comparing base (9fff07d) to head (23d2b5b).
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/config/request.rs 55.55% 4 Missing ⚠️
crates/matrix-sdk/src/authentication/oauth/mod.rs 94.11% 1 Missing ⚠️
crates/matrix-sdk/src/http_client/mod.rs 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5822      +/-   ##
==========================================
- Coverage   88.52%   88.51%   -0.01%     
==========================================
  Files         361      361              
  Lines      101331   101367      +36     
  Branches   101331   101367      +36     
==========================================
+ Hits        89702    89730      +28     
- Misses       7426     7434       +8     
  Partials     4203     4203              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling /versions no longer works when the access token requires a refresh (via MAS).

4 participants