Skip to content

Conversation

@zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Oct 1, 2025

It doesn't make sense to send a formatted caption without a plain text caption so using TextMessageEventContent forces the latter to be present.

This also allows to use the helpful constructors of TextMessageEventContent.

It doesn't make sense to send a formatted caption without a plain text
caption so using TextMessageEventContent forces the latter to be present.

This also allows to use the helpful constructors of
TextMessageEventContent.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner October 1, 2025 12:39
@zecakeh zecakeh requested review from poljar and removed request for a team October 1, 2025 12:39
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 1, 2025

CodSpeed Performance Report

Merging #5733 will not alter performance

Comparing zecakeh:caption-text-message (b94cdfc) with main (681b221)

Summary

✅ 50 untouched

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.39%. Comparing base (59b7da2) to head (b94cdfc).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5733      +/-   ##
==========================================
- Coverage   88.40%   88.39%   -0.02%     
==========================================
  Files         359      359              
  Lines       99048    99032      -16     
  Branches    99048    99032      -16     
==========================================
- Hits        87566    87540      -26     
- Misses       7344     7357      +13     
+ Partials     4138     4135       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan merged commit 6072618 into matrix-org:main Oct 2, 2025
83 of 85 checks passed
@zecakeh zecakeh deleted the caption-text-message branch October 2, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants