feat(element-call url params): split url params into configuration and properties

[toger5]

This PR is part of an onging effort to move responsiblity to the EC app and out of the EX apps.

4 intends (f.ex join_existing start_new_dm... ) (as url paramters) are introduced in recent element call versions. Those intends behave like defaults. If an intend is set a set of url parameters are predefined.
Not all params can be covered by the intend (for insteance the widget_id or the host_url).
This PR splits the url parameters into configuration (things that can be configured by the intent) and properties (things that still need to be passed one by one)

The goal with this change is that EX only needs to configre the intent once and the EC codebase can update the behavior in those 4 specific scenarios in case new features come along (auto hangup when other participants leave, send call ring notification...)

Signed-off-by: Timo K toger5@hotmail.de

• Public API changes documented in changelogs (optional)

Signed-off-by:

[codspeed-hq]

CodSpeed Performance Report

Merging #5560 will not alter performance

_{Comparing toger5/intent-system-call-url (207255f) with main (441b006)}

Summary

✅ 49 untouched benchmarks

[codecov]

Codecov Report

❌ Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.89%. Comparing base (441b006) to head (207255f).
⚠️ Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
...tes/matrix-sdk/src/widget/settings/element_call.rs	98.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5560      +/-   ##
==========================================
- Coverage   88.89%   88.89%   -0.01%     
==========================================
  Files         349      349              
  Lines       96546    96542       -4     
  Branches    96546    96542       -4     
==========================================
- Hits        85826    85821       -5     
- Misses       6682     6683       +1     
  Partials     4038     4038              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Hywan]

Thanks for the patches.

Can you amend your patches to provide a description please? Your first patch's description is “d”, and the second is “fix tests”. I don't think “d” is enough information to help the reviewer to understand it.

[Hywan]

Thanks for the changes. I am approving the changes. Can you answer my questions though :-)?

[Hywan]

What Option<bool> means here? Specifically, how Some(false) is different from None?

[Hywan]

Same question as above.

[Hywan]

Same question as above.

[Hywan]

Same question as above.

[Hywan]

Same question as above :-).

[Hywan]

Guess what ^^?

[Hywan]

What happens if it's 0? Is it allowed?

[toger5]

It would set the font size to 0. Since EC is a webview this would imply that text is basically "not rendered".

I think this is the expected behavior. Since css allso does not do any specific allow rules on this I feel like the url params can have the same flexibility.

[toger5]

@Hywan sorry for the high latency on this PR. (Holidays)

I will work on a rebase/merge today.

What Option means here? Specifically, how Some(false) is different from None?

The ElementCallParams are directly translated into url query parameters.
All fields are optionals where the None case implies, that it will not be part of the url parameters.

For example:

ElementCallParams {
   hide_screensharing: Some(true),
   ..ElementCallParams::default()
}

will become:

my.url?hide_screensharing=true

The reason it might be desirable to not list those configurations in the urls parameters is that the intent implies default for all configuration values in widget itself. Setting the url parameter specifically will overwrite those defaults. So it often is desired for them to be None values (not part of the url).

I will update the docstring to contain this information as well.

[Hywan]

Thanks!