fix(sdk): Handle 520 HTTP status code as a permanent error
#5105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5105 +/- ##
=======================================
Coverage 85.77% 85.78%
=======================================
Files 333 333
Lines 36244 36246 +2
=======================================
+ Hits 31089 31092 +3
+ Misses 5155 5154 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
poljar
approved these changes
May 27, 2025
Contributor
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
This might be changelog worthy. Looks good otherwise.
jmartinesp
force-pushed
the
fix/handle-520-http-status-code-as-a-permanent-error
branch
from
d212199 to
faa7a95
Compare
The status code is usually returned by Cloudflare to indicate an unknown server error, so we should cancel the upload and let the user retry if they want to.
jmartinesp
force-pushed
the
fix/handle-520-http-status-code-as-a-permanent-error
branch
from
faa7a95 to
ea7f65a
Compare
jmartinesp
deleted the
fix/handle-520-http-status-code-as-a-permanent-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status code is usually returned by Cloudflare to indicate an unknown server error, so we should cancel the upload and let the user retry if they want to.
Signed-off-by: