feat(sdk&ffi): report room api #4713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>
Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>
Signed-off-by: hanadi92 <hanadi.tamimi@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4713 +/- ##
=======================================
Coverage 85.97% 85.98%
=======================================
Files 290 290
Lines 34065 34069 +4
=======================================
+ Hits 29288 29294 +6
+ Misses 4777 4775 -2 ☔ View full report in Codecov by Sentry. |
Hywan
reviewed
Feb 26, 2025
Member
Hywan
left a comment
Hywan
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I've a renaming suggestion but everything else looks sane to me.
crates/matrix-sdk/src/room/mod.rs
Outdated
| /// # Errors | ||
| /// | ||
| /// Returns an error if the room is not found or on rate limit | ||
| pub async fn report_room( |
Member
There was a problem hiding this comment.
I think the method name should be report, thoughts?
Member
There was a problem hiding this comment.
Could be ambiguous with respect to reporting a user?
Member
There was a problem hiding this comment.
Hmm indeed. Let's keep report_room then.
bindings/matrix-sdk-ffi/src/room.rs
Outdated
| /// # Errors | ||
| /// | ||
| /// Returns an error if the room is not found or on rate limit | ||
| pub async fn report_room( |
Hywan
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves this #4681
Signed-off-by: @hanadi92 hanadi.tamimi@gmail.com