Make timeline pagination more flexible and smarter #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
jplatte
commented
Jan 6, 2023
Collaborator
Author
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Not at my computer anymore, but just realized a mistake.
manuroe
reviewed
Jan 9, 2023
| /// The beginning of the visible timeline. | ||
| /// | ||
| /// There might be earlier events the user is not allowed to see due to | ||
| /// history visibility. |
Contributor
There was a problem hiding this comment.
Thanks for exposing this case!
poljar
approved these changes
Jan 9, 2023
Contributor
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Looks mostly sensible, if we can get rid of the expect that would be great.
poljar
approved these changes
Jan 10, 2023
- Don't actually fire off a request when the top of the timeline has already been reached - Allow making multiple requests without removing the loading indicator in between
jplatte
force-pushed
the
jplatte/timeline-pagination-2
branch
from
bb8f50c to
051d9f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimelineStartvirtual timeline item