Skip to content

Commit 6b36312

Browse files
committed
fix(sdk): Fix errors & warnings w/ experimental-timeline, w/o e2e-encryption
1 parent 4bafb38 commit 6b36312

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

crates/matrix-sdk/src/room/timeline/event_handler.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -352,6 +352,7 @@ enum TimelineEventKind {
352352
enum TimelineItemPosition {
353353
Start,
354354
End,
355+
#[cfg(feature = "e2e-encryption")]
355356
Update(usize),
356357
}
357358

@@ -627,6 +628,7 @@ impl<'a, 'i> TimelineEventHandler<'a, 'i> {
627628
match position {
628629
TimelineItemPosition::Start => self.timeline_items.insert_cloned(0, item),
629630
TimelineItemPosition::End => self.timeline_items.push_cloned(item),
631+
#[cfg(feature = "e2e-encryption")]
630632
TimelineItemPosition::Update(idx) => self.timeline_items.set_cloned(*idx, item),
631633
}
632634
}

crates/matrix-sdk/src/room/timeline/mod.rs

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
1919
use std::{
2020
collections::HashMap,
21-
iter,
2221
sync::{Arc, Mutex as StdMutex},
2322
};
2423

@@ -29,7 +28,7 @@ use ruma::{
2928
assign,
3029
events::{
3130
fully_read::FullyReadEventContent, reaction::Relation as AnnotationRelation,
32-
room_key::ToDeviceRoomKeyEvent, AnyMessageLikeEventContent,
31+
AnyMessageLikeEventContent,
3332
},
3433
OwnedEventId, OwnedUserId, TransactionId, UInt,
3534
};
@@ -39,7 +38,7 @@ use super::{Joined, Room};
3938
use crate::{
4039
event_handler::EventHandlerDropGuard,
4140
room::{self, MessagesOptions},
42-
Client, Result,
41+
Result,
4342
};
4443

4544
mod event_handler;
@@ -69,6 +68,7 @@ pub struct Timeline {
6968
_end_token: StdMutex<Option<String>>,
7069
_timeline_event_handler_guard: EventHandlerDropGuard,
7170
_fully_read_handler_guard: EventHandlerDropGuard,
71+
#[cfg(feature = "e2e-encryption")]
7272
_room_key_handler_guard: EventHandlerDropGuard,
7373
}
7474

@@ -129,8 +129,16 @@ impl Timeline {
129129

130130
// Not using room.add_event_handler here because RoomKey events are
131131
// to-device events that are not received in the context of a room.
132+
#[cfg(feature = "e2e-encryption")]
132133
let room_id = room.room_id().to_owned();
134+
#[cfg(feature = "e2e-encryption")]
133135
let room_key_handle = room.client.add_event_handler({
136+
use std::iter;
137+
138+
use ruma::events::room_key::ToDeviceRoomKeyEvent;
139+
140+
use crate::Client;
141+
134142
let inner = inner.clone();
135143
move |event: ToDeviceRoomKeyEvent, client: Client| {
136144
let inner = inner.clone();
@@ -162,6 +170,7 @@ impl Timeline {
162170
}
163171
}
164172
});
173+
#[cfg(feature = "e2e-encryption")]
165174
let _room_key_handler_guard = room.client.event_handler_drop_guard(room_key_handle);
166175

167176
Timeline {
@@ -171,6 +180,7 @@ impl Timeline {
171180
_end_token: StdMutex::new(None),
172181
_timeline_event_handler_guard,
173182
_fully_read_handler_guard,
183+
#[cfg(feature = "e2e-encryption")]
174184
_room_key_handler_guard,
175185
}
176186
}

0 commit comments

Comments
 (0)