This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add input device selection during voice broadcast #9620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weeman1337
added
the
T-Task
weeman1337
force-pushed
the
weeman1337/voice-broadcast-recording-pip-devices
branch
from
6f9e5a0 to
e1bc97a
Compare
weeman1337
force-pushed
the
weeman1337/voice-broadcast-recording-pip-devices
branch
from
e1bc97a to
0cd7dc2
Compare
germain-gg
suggested changes
Nov 25, 2022
Contributor
germain-gg
left a comment
germain-gg
left a comment
There was a problem hiding this comment.
Code looks good to me, I believe we should slightly rework the hook separation of logic before this lands
weeman1337
deleted the
weeman1337/voice-broadcast-recording-pip-devices
branch
amywalkerdev
pushed a commit
that referenced
this pull request
Nov 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#23282
Short pause when changing the device is expected
PSF-1599
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.