Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Fix clickable area of advanced toggle on appearance user settings tab #8820

Merged
SimonBrandner merged 1 commit into from
Jun 12, 2022
Merged

Fix clickable area of advanced toggle on appearance user settings tab #8820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions res/css/views/settings/tabs/user/_AppearanceUserSettingsTab.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ limitations under the License.
margin-bottom: 16px;
}

.mx_AppearanceUserSettingsTab_AdvancedToggle {
color: $accent;
cursor: pointer;
}

.mx_AppearanceUserSettingsTab_systemFont {
margin-left: calc($font-16px + 10px);
}
Expand Down
7 changes: 4 additions & 3 deletions src/components/views/settings/tabs/user/AppearanceUserSettingsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { MatrixClientPeg } from '../../../../../MatrixClientPeg';
import SettingsStore from "../../../../../settings/SettingsStore";
import SettingsFlag from '../../../elements/SettingsFlag';
import Field from '../../../elements/Field';
import AccessibleButton from "../../../elements/AccessibleButton";
import { SettingLevel } from "../../../../../settings/SettingLevel";
import { UIFeature } from "../../../../../settings/UIFeature";
import { Layout } from "../../../../../settings/enums/Layout";
Expand Down Expand Up @@ -90,12 +91,12 @@ export default class AppearanceUserSettingsTab extends React.Component<IProps, I
if (!SettingsStore.getValue(UIFeature.AdvancedSettings)) return null;

const brand = SdkConfig.get().brand;
const toggle = <div
className="mx_AppearanceUserSettingsTab_AdvancedToggle"
const toggle = <AccessibleButton
kind="link"
onClick={() => this.setState({ showAdvanced: !this.state.showAdvanced })}
>
{ this.state.showAdvanced ? _t("Hide advanced") : _t("Show advanced") }
</div>;
</AccessibleButton>;

let advanced: React.ReactNode;

Expand Down