Improve subspaces and some utilities around room/space creation

[t3chguy]

Fixes element-hq/element-web#18090
Fixes element-hq/element-web#18091
Fixes element-hq/element-web#17256

[germain-gg]

Overall looks great to me 👏

[niquewoodhouse]

Review:

Medium things

• The add existing spaces dialog seems to have a rogue No results item

• When I added an existing space from the 'add' button on the explore space page, the added space disappears from the spaces panel (makes sense) and the rooms within it are absorbed into the room list (makes sense), the subspace got added to the spaces panel (makes sense), but the 'explore space view' didn't update (only the room list did).

• Missing microcopy on the add space dialog (I think this was my oversight)

We use this elsewhere, I think it's actually as useful here as anywhere else.

If its set to private (invite only), copy says "Only inviting people will be able to find and join"; if public "anyone in Space name will be able to find and join."

Small things

Would be nice if the text between the badge and the supporting copy could align better. eg

[t3chguy]

When I added an existing space from the 'add' button on the explore space page, the added space disappears from the spaces panel (makes sense) and the rooms within it are absorbed into the room list (makes sense), the subspace got added to the spaces panel (makes sense), but the 'explore space view' didn't update (only the room list did).

Fixed

Missing microcopy on the add space dialog (I think this was my oversight)

Added

Would be nice if the text between the badge and the supporting copy could align better. eg

Fixed

[niquewoodhouse]

Copy is...not true, or is it? I'm not sure but...are these subspaces just going to be set to just members of the space, or anyone anywhere? Rooms will have 3 options - space members, private and public - these just have the final 2?

[nadonomy]

Are we confident we want to expose subspace as nomenclature? It’s ringing off jargon alarm bells for me. Wondering if the UI should simply stick to spaces for now?

…

On Wed, 28 Jul 2021 at 19:35, Nique Woodhouse ***@***.***> wrote: ***@***.**** requested changes on this pull request. [image: image] <https://user-images.githubusercontent.com/1587166/127377073-5ce1d11a-5944-47fc-9343-b1faf14b6a88.png> Copy is...not true, or is it? I'm not sure but...are these subspaces just going to be set to just members of the space, or anyone anywhere? Rooms will have 3 options - space members, private and public - these just have the final 2? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#6458 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDJTMJWDQ6JZZZVPP7IOJLT2BEYLANCNFSM5A3P7BOQ> .

[niquewoodhouse]

Are we confident we want to expose subspace as nomenclature? It’s ringing off jargon alarm bells for me. Wondering if the UI should simply stick to spaces for now?

I don't feel super strongly. The original designs had space too but in the delight team, people got confused as to what it meant, so changed it. My theory was a folder in a folder is a folder, not a subfolder but I have seen some external people in the feedback room refer to them as 'subspaces' so it makes me think it's possibly understood, but that might be just be more technical people who picked up the term from the room?

[t3chguy]

Copy is...not true, or is it? I'm not sure but...are these subspaces just going to be set to just members of the space, or anyone anywhere? Rooms will have 3 options - space members, private and public - these just have the final 2?

Copy is...not true, or is it?

The copy matches the dropdown, public = everyone;

• these just have the final 2?

Why?

What if you have an organisation e.g Element but want a public subspace for public relations
or what if you're a public space like Matrix Community, are you going to force everyone to join Matrix Community to be able to join any subspaces?

Given that you can create a public space and add it as a subspace to another space this is a possible scenario by jumping through UX hoops anyway.

subspaces

Happy to change all references to Spaces if that is better

[niquewoodhouse]

• these just have the final 2?

Why?

Just to clarify, I was asking why they only have 2 options and not the 3 options as intended. And then you reminded me it's because my server doesn't yet have the restricted rooms upgrade, which makes sense, thanks.

[niquewoodhouse]

@nadonomy @t3chguy can we go ahead with this plan: Change subspace to space and see what reaction we get from people, ahead of exiting beta, and just make a decision at that point what we do?

[t3chguy]

Updated copy

[github-actions]

Here's what your changelog entry will look like:

🐛 Bug Fixes

• Improve subspaces and some utilities around room/space creation (#6458). Fixes M11.9 Label subspaces as beta element-hq/element-web#18090 M11.10 Better expose adding spaces as subspaces element-hq/element-web#18091 and Creating subspaces is very unintuitive element-hq/element-web#17256.