Fix broken "Go to Home View" shortcut on macOS #5818
Conversation
The previous shortcut CMD+OPT+H is already bound by the system (hide other windows) and cannot be overridden. This commit changes the shortcut to CTRL+SHIFT+H on macOS while keeping CTRL+ALT+H on other platforms. Note that both CTRL+OPT+H (hide cursor) and CTRL+H (delete previous character) are bound by the system as well and wouldn't have worked as a replacement. Fixes: element-hq/element-web#16692 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
force-pushed
the
feature/mac-go-home
branch
from
efb8cf3 to
c7fcf2a
Compare
SimonBrandner
left a comment
SimonBrandner
left a comment
There was a problem hiding this comment.
This looks fine code-wise, but I don't like this solution much. In the future, there will be a need for figuring out a different way to handle this since it doesn't play well with customizable keybindings (there should be sane cross-platform defaults to allow for syncing).
I think the underlying problem is that the H shortcut is overloaded on macOS. If we could switch to another letter, that might make it easier to find a cross platform shortcut. |
That was what I was thinking, but let's not worry about it now since I'd like to make these changes in bulk with others since there are some other non-cross-platform shortcuts |
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks! I agree it's a bit unfortunate all around, but this seems reasonable enough for now at least.
3 participants
The previous shortcut CMD+OPT+H is already bound by the system (hide other windows) and cannot be overridden. This commit changes the shortcut to CTRL+SHIFT+H on macOS while keeping CTRL+ALT+H on other platforms.
Note that both CTRL+OPT+H (hide cursor) and CTRL+H (delete previous character) are bound by the system as well and wouldn't have worked as a replacement.
Fixes: element-hq/element-web#16692
Signed-off-by: Johannes Marbach n0-0ne+github@mailbox.org