This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix Filepanel scroll position state lost when room is changed #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThobyV
changed the title
turt2live
approved these changes
Apr 17, 2020
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
Overall this looks great from a code perspective, thanks! I haven't tested it personally yet, but it seems to do the right thing.
Member
|
One thing though, we don't have a way to jump back to bottom do we? So if we store where we scrolled, then come back a few weeks later, we'll probably never get back to the bottom, right? |
Member
|
Oh, yes. That sounds like it should be its own bug though. |
Member
|
Imo this shouldn't have landed without a way to annul it |
Member
|
yea, good point. Let's revert it pending some conversations with design. Sorry @ThobyV :( |
This was referenced Apr 20, 2020
Contributor
Author
|
@turt2live has this issue been fixed already? Also is there a design discussion on it. |
Member
|
Any discussion should go here: element-hq/element-web#13409 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes element-hq/element-web#13018
Signed-off-by: thobyv-kismat vivee18@gmail.com