This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Disable jump to read receipt button instead of hiding when nothing to jump to - #12863
Merged
Conversation
…en no RR Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
added
the
T-Enhancement
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
dbkr
reviewed
Aug 6, 2024
| "ignore_confirm_title": "Ignore %(user)s", | ||
| "invited_by": "Invited by %(sender)s", | ||
| "jump_to_rr_button": "Jump to read receipt", | ||
| "jump_to_rr_button_disabled": "This feature is disabled", |
Member
There was a problem hiding this comment.
This feels a bit overly unhelpful. Conditional that shows either, "Not available in spaces" or, "No receipts for ${user}" depending on isSpace?
Member
Author
There was a problem hiding this comment.
The tooltip is now gone (forgot to push), but this would have been as specified by design. See element-hq/element-web#27883 (comment)
dbkr
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#27883