Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Extract SearchScope and SearchInfo into Searching #12698

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Extract SearchScope and SearchInfo into Searching #12698

merged 5 commits into from
Jun 26, 2024

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 25, 2024

Subset of #12677

@t3chguy
Extract SearchScope and SearchInfo into Searching
f9992d9 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 25, 2024
@t3chguy t3chguy self-assigned this Jun 25, 2024
@t3chguy
delint
a62daf0 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
delint
b545979 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Fix test
9950fb2 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy marked this pull request as ready for review June 25, 2024 16:21
@t3chguy t3chguy requested a review from a team as a code owner June 25, 2024 16:21
@t3chguy t3chguy mentioned this pull request Jun 26, 2024
Merged
richvdh
richvdh approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I guess.

I assume if you're moving these things, you must know what they are. It would be a good opportunity to document them. But since this is just moving existing code, I won't insist.

@t3chguy
Comments
5fc5dd2 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy enabled auto-merge June 26, 2024 10:42
@t3chguy t3chguy added this pull request to the merge queue Jun 26, 2024
Merged via the queue into develop with commit 7247524 Jun 26, 2024
29 checks passed
@t3chguy t3chguy deleted the t3chguy/extract-searching branch June 26, 2024 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh approved these changes

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @richvdh