Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Mark all threads as read button #12378

Merged
merged 15 commits into from
Mar 28, 2024
Merged

Mark all threads as read button #12378

merged 15 commits into from
Mar 28, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Mar 26, 2024 •
edited
Loading

Fixes #12378

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@dbkr dbkr added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Mar 26, 2024
@dbkr dbkr marked this pull request as ready for review March 28, 2024 14:56
@dbkr dbkr requested a review from a team as a code owner March 28, 2024 14:56
florianduros
florianduros approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

Small improvement can be made I think

src/components/structures/ThreadPanel.tsx Outdated Show resolved Hide resolved
src/components/structures/ThreadPanel.tsx Outdated Show resolved Hide resolved
res/css/views/right_panel/_ThreadPanel.pcss Outdated Show resolved Hide resolved
res/css/views/right_panel/_ThreadPanel.pcss Outdated Show resolved Hide resolved
playwright/e2e/spaces/threads-activity-centre/threadsActivityCentre.spec.ts Outdated Show resolved Hide resolved
test/components/structures/ThreadPanel-test.tsx Outdated Show resolved Hide resolved
test/components/structures/ThreadPanel-test.tsx Outdated Show resolved Hide resolved
dbkr and others added 4 commits March 28, 2024 15:39
@dbkr @florianduros
Use dedicated useMatrixClientContext function
020fa81 
Co-authored-by: Florian Duros <florianduros@element.io>
@dbkr @florianduros
Use dedicated useRoomContext function
86083e4 
Co-authored-by: Florian Duros <florianduros@element.io>
@dbkr @florianduros
Compound spacing variables
eca7159 
Co-authored-by: Florian Duros <florianduros@element.io>
@dbkr @florianduros
Compound spacing variables
1c10283 
Co-authored-by: Florian Duros <florianduros@element.io>
@dbkr dbkr added this pull request to the merge queue Mar 28, 2024
Merged via the queue into develop with commit 4ae94ae Mar 28, 2024
22 checks passed
@dbkr dbkr deleted the dbkr/mark_threads_unread branch March 28, 2024 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@florianduros florianduros florianduros approved these changes

@richvdh richvdh Awaiting requested review from richvdh richvdh is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbkr @florianduros