This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Manage style rules related to mx_RoomView_body on _RoomView.pcss and mx_MessageComposer on _MessageComposer.pcss
#10732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Z-Community-PR
luixxiul
commented
Apr 27, 2023
| @@ -110,6 +110,17 @@ limitations under the License. | |||
| .mx_RoomView_messagePanelSearchSpinner { | |||
| order: 2; | |||
| } | |||
|
|
|||
| &[data-layout="bubble"] { | |||
| /* Make widgets and calls span across the whole room width when using bubble layout */ | |||
There was a problem hiding this comment.
This comment was taken from the title of #7553.
…and `mx_MessageComposer` on `_MessageComposer.pcss` This block does not actually style mx_EventTile, instead elements related to 'mx_RoomView_body' and `mx_MessageComposer`. Because those selectors have been already managed on CSS files of each component, the rules should be placed on those files.
luixxiul
changed the title
mx_RoomView_body on _RoomView.pcssmx_RoomView_body on _RoomView.pcss and mx_MessageComposer on _MessageComposer.pcss
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests to move style rules related to
mx_RoomView_bodyandmx_MessageComposerfrom_EventBubbleTile.pcssto_RoomView.pcssand_MessageComposer.pcssThe style block does not actually style
mx_EventTile, instead elements related tomx_RoomView_bodyandmx_MessageComposer. Because those selectors have been already managed on CSS files of each component, the rules should be placed on those files.type: task
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.