update setting naming to match style

Author: t3chguy

src/components/views/settings/tabs/user/PreferencesUserSettingsTab.tsx

@@ -49,7 +49,7 @@ export default class PreferencesUserSettingsTab extends React.Component<{}, ISta
     ];
 
     static SPACES_SETTINGS = [
-        "Spaces.all_rooms_in_home",
+        "Spaces.allRoomsInHome",
     ];
 
     static KEYBINDINGS_SETTINGS = [

src/components/views/spaces/SpacePanel.tsx

@@ -83,7 +83,7 @@ const HomeButtonContextMenu = ({ onFinished, ...props }: ComponentProps<typeof S
                 label={_t("Show all rooms")}
                 active={allRoomsInHome}
                 onClick={() => {
-                    SettingsStore.setValue("Spaces.all_rooms_in_home", null, SettingLevel.ACCOUNT, !allRoomsInHome);
+                    SettingsStore.setValue("Spaces.allRoomsInHome", null, SettingLevel.ACCOUNT, !allRoomsInHome);
                 }}
             />
         </IconizedContextMenuOptionList>

src/settings/Settings.tsx

@@ -749,7 +749,7 @@ export const SETTINGS: {[setting: string]: ISetting} = {
         supportedLevels: LEVELS_ACCOUNT_SETTINGS,
         default: null,
     },
-    "Spaces.all_rooms_in_home": {
+    "Spaces.allRoomsInHome": {
         displayName: _td("Show all rooms in Home"),
         description: _td("All rooms you're in will appear in Home."),
         supportedLevels: LEVELS_ACCOUNT_SETTINGS,

src/stores/SpaceStore.tsx

@@ -117,12 +117,12 @@ export class SpaceStoreClass extends AsyncStoreWithClient<IState> {
     private _invitedSpaces = new Set<Room>();
     private spaceOrderLocalEchoMap = new Map<string, string>();
     private _restrictedJoinRuleSupport?: IRoomCapability;
-    private _allRoomsInHome: boolean = SettingsStore.getValue("Spaces.all_rooms_in_home");
+    private _allRoomsInHome: boolean = SettingsStore.getValue("Spaces.allRoomsInHome");
 
     constructor() {
         super(defaultDispatcher, {});
 
-        SettingsStore.monitorSetting("Spaces.all_rooms_in_home", null);
+        SettingsStore.monitorSetting("Spaces.allRoomsInHome", null);
     }
 
     public get invitedSpaces(): Room[] {
@@ -812,8 +812,8 @@ export class SpaceStoreClass extends AsyncStoreWithClient<IState> {
 
             case Action.SettingUpdated: {
                 const settingUpdatedPayload = payload as SettingUpdatedPayload;
-                if (settingUpdatedPayload.settingName === "Spaces.all_rooms_in_home") {
-                    const newValue = SettingsStore.getValue("Spaces.all_rooms_in_home");
+                if (settingUpdatedPayload.settingName === "Spaces.allRoomsInHome") {
+                    const newValue = SettingsStore.getValue("Spaces.allRoomsInHome");
                     if (this.allRoomsInHome !== newValue) {
                         this._allRoomsInHome = newValue;
                         this.emit(UPDATE_HOME_BEHAVIOUR, this.allRoomsInHome);

test/stores/SpaceStore-test.ts

@@ -85,7 +85,7 @@ describe("SpaceStore", () => {
     const setShowAllRooms = async (value: boolean) => {
         if (store.allRoomsInHome === value) return;
         const emitProm = testUtils.emitPromise(store, UPDATE_HOME_BEHAVIOUR);
-        await SettingsStore.setValue("Spaces.all_rooms_in_home", null, SettingLevel.DEVICE, value);
+        await SettingsStore.setValue("Spaces.allRoomsInHome", null, SettingLevel.DEVICE, value);
         jest.runAllTimers(); // run async dispatch
         await emitProm;
     };

test/stores/room-list/SpaceWatcher-test.ts

@@ -47,7 +47,7 @@ describe("SpaceWatcher", () => {
 
     const setShowAllRooms = async (value: boolean) => {
         if (store.allRoomsInHome === value) return;
-        await SettingsStore.setValue("Spaces.all_rooms_in_home", null, SettingLevel.DEVICE, value);
+        await SettingsStore.setValue("Spaces.allRoomsInHome", null, SettingLevel.DEVICE, value);
         await testUtils.emitPromise(store, UPDATE_HOME_BEHAVIOUR);
     };