Add an MXCUri class for representing media uri's in matrix #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
reviewed
Jul 18, 2022
clokep
reviewed
Jul 18, 2022
clokep
reviewed
Jul 18, 2022
clokep
reviewed
Jul 18, 2022
clokep
reviewed
Sep 8, 2022
clokep
reviewed
Sep 8, 2022
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
clokep
approved these changes
Sep 12, 2022
This was referenced Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from matrix-org/synapse#13162 to allow other projects to use the same class.
This PR:
MXCUriclass (under a newtypesmodule) which is used to represent MXC URIs in Matrix. The class is mostly useful for validating URIs as well as providing methods for converting from a str and back.As noted in matrix-org/synapse#13162 (comment), the validation here is quite loose, as the exact grammar for mxc uri's is still not set in stone (see matrix-org/matrix-spec#503).