Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new event type for verification requests #3514

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jun 26, 2023

Previous PRs (#3449, etc) have pulled out an interface from the VerificationRequest class, but applications registering for the CryptoEvent.VerificationRequest event could still be expecting a fully-fledged class rather than the interface.

To handle this without breaking backwards compat, add a new event type that carries the interface, not the class.

based on #3515

Notes: Deprecate Crypto.VerificationRequest application event, replacing it with Crypto.VerificationRequestReceived.


Here's what your changelog entry will look like:

🦖 Deprecations

  • Deprecate Crypto.VerificationRequest application event, replacing it with Crypto.VerificationRequestReceived. (#3514).

@richvdh richvdh added the T-Deprecation A pull request that makes something deprecated label Jun 26, 2023
richvdh added a commit to matrix-org/matrix-react-sdk that referenced this pull request Jun 26, 2023
matrix-org/matrix-js-sdk#3514 deprecates
`CryptoEvent.VerificationRequest` in favour of
`CryptoEvent.VerificationRequestReceived`. Use the new event.
@richvdh richvdh force-pushed the rav/element-r/28_cancel_request branch from 1398ac0 to 85e0ddf Compare June 26, 2023 15:23
@richvdh richvdh force-pushed the rav/element-r/29_verification_request_received_event branch from 1430d43 to fdef109 Compare June 26, 2023 15:24
Base automatically changed from rav/element-r/28_cancel_request to develop June 26, 2023 17:11
Previous PRs (#3449, etc) have
pulled out an interface from the `VerificationRequest` class, but applications
registering for the `CryptoEvent.VerificationRequest` event could still be
expecting a fully-fledged class rather than the interface.

To handle this without breaking backwards compat, add a new event type that
carries the interface, not the class.
@richvdh richvdh force-pushed the rav/element-r/29_verification_request_received_event branch from fdef109 to 9a25afb Compare June 26, 2023 17:16
@richvdh richvdh changed the base branch from develop to rav/element-r/30_fix_test_timeout June 26, 2023 17:17
@richvdh richvdh marked this pull request as ready for review June 26, 2023 17:43
@richvdh richvdh requested a review from a team as a code owner June 26, 2023 17:43
@richvdh richvdh requested review from weeman1337 and robintown and removed request for a team June 26, 2023 17:43
Base automatically changed from rav/element-r/30_fix_test_timeout to develop June 26, 2023 21:15
@richvdh richvdh added this pull request to the merge queue Jun 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 26, 2023
@richvdh richvdh added this pull request to the merge queue Jun 27, 2023
Merged via the queue into develop with commit 1862616 Jun 27, 2023
@richvdh richvdh deleted the rav/element-r/29_verification_request_received_event branch June 27, 2023 12:16
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this pull request Jun 28, 2023
matrix-org/matrix-js-sdk#3514 deprecates
`CryptoEvent.VerificationRequest` in favour of
`CryptoEvent.VerificationRequestReceived`. Use the new event.
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this pull request Jun 28, 2023
…icesForUser` (#11152)

* Use new `CryptoEvent.VerificationRequestReceived` event

matrix-org/matrix-js-sdk#3514 deprecates
`CryptoEvent.VerificationRequest` in favour of
`CryptoEvent.VerificationRequestReceived`. Use the new event.

* Factor out `getDeviceCryptoInfo` function

I seem to be writing this logic several times, so let's factor it out.

* Factor out `getUserDeviceIds` function

Another utility function

* VerificationRequestToast: `getStoredDevice` -> `getDeviceCryptoInfo`

* SlashCommands: `getStoredDevice` -> `getDeviceCryptoInfo`

* MemberTile: `getStoredDevicesForUser` -> `getUserDeviceIds`

* Remove redundant mock of `getStoredDevicesForUser`
richvdh added a commit to matrix-org/matrix-react-sdk that referenced this pull request Jun 30, 2023
richvdh added a commit to matrix-org/matrix-react-sdk that referenced this pull request Jun 30, 2023
richvdh added a commit to matrix-org/matrix-react-sdk that referenced this pull request Jul 3, 2023
github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this pull request Jul 7, 2023
* Cypress: `crypto.verification.request` -> `crypto.verificationRequestReceived`

matrix-org/matrix-js-sdk#3514 deprecated crypto.verification.request.

* Cypress: `beginKeyVerification` -> `startVerification`

matrix-org/matrix-js-sdk#3528 deprecated beginKeyVerification

* simplify `setupBotClient`

no functional change here, just combining the various `cy.wrap()`ed things into
a single async func

* Cypress: Use Rust crypto for the bot user in verification tests

We can already start using the Rust crypto implementation for the "bot" user in
the verification tests!
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Feb 24, 2024
* Drop support for Node 16 ([\matrix-org#3533](matrix-org#3533)).
* Improve types around login, registration, UIA and identity servers ([\matrix-org#3537](matrix-org#3537)).
* **The Browserify artifact is being deprecated, scheduled for removal in the October 10th release cycle. (matrix-org#3189)**
* Simplify `MatrixClient::setPowerLevel` API ([\matrix-org#3570](matrix-org#3570)). Fixes element-hq/element-web#13900 and matrix-org#1844.
* Deprecate `VerificationRequest.getQRCodeBytes` and replace it with the asynchronous `generateQRCode`. ([\matrix-org#3562](matrix-org#3562)).
* Deprecate `VerificationRequest.beginKeyVerification()` in favour of `VerificationRequest.startVerification()`. ([\matrix-org#3528](matrix-org#3528)).
* Deprecate `Crypto.VerificationRequest` application event, replacing it with `Crypto.VerificationRequestReceived`. ([\matrix-org#3514](matrix-org#3514)).
* Throw saner error when peeking has its room pulled out from under it ([\matrix-org#3577](matrix-org#3577)). Fixes element-hq/element-web#18679.
* OIDC: Log in ([\matrix-org#3554](matrix-org#3554)). Contributed by @kerryarchibald.
* Prevent threads code from making identical simultaneous API hits ([\matrix-org#3541](matrix-org#3541)). Fixes element-hq/element-web#25395.
* Update IUnsigned type to be extensible ([\matrix-org#3547](matrix-org#3547)).
* add stop() api to BackupManager for clean shutdown ([\matrix-org#3553](matrix-org#3553)).
* Log the message ID of any undecryptable to-device messages ([\matrix-org#3543](matrix-org#3543)).
* Ignore thread relations on state events for consistency with edits ([\matrix-org#3540](matrix-org#3540)).
* OIDC: validate id token ([\matrix-org#3531](matrix-org#3531)). Contributed by @kerryarchibald.
* Fix read receipt sending behaviour around thread roots ([\matrix-org#3600](matrix-org#3600)).
* Fix `TypedEventEmitter::removeAllListeners(void)` not working ([\matrix-org#3561](matrix-org#3561)).
* Don't allow Olm unwedging rate-limiting to race ([\matrix-org#3549](matrix-org#3549)). Fixes element-hq/element-web#25716.
* Fix an instance of failed to decrypt error when an in flight `/keys/query` fails. ([\matrix-org#3486](matrix-org#3486)).
* Use the right anchor emoji for SAS verification ([\matrix-org#3534](matrix-org#3534)).
* fix a bug which caused the wrong emoji to be shown during SAS device verification. ([\matrix-org#3523](matrix-org#3523)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Deprecation A pull request that makes something deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants