Skip to content

Conversation

@germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Jan 30, 2023

A lot of logic regarding servers that do not support thread notifications (pre MSC3773) exists. This PR removes some of it.
Comes with its react-sdk counterpart too.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@germain-gg germain-gg added the T-Task Tasks for the team like planning label Jan 30, 2023
@germain-gg germain-gg force-pushed the gsouquet/deprecate-thread-clientnotifications branch from 5e54765 to 9aef319 Compare January 30, 2023 17:34
@germain-gg germain-gg marked this pull request as ready for review January 30, 2023 17:55
@germain-gg germain-gg requested a review from a team as a code owner January 30, 2023 17:55
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems plausible

@germain-gg germain-gg merged commit 6c6304a into develop Jan 31, 2023
@germain-gg germain-gg deleted the gsouquet/deprecate-thread-clientnotifications branch January 31, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants