Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace .at(-1) with array.length-1 #3080

Merged
merged 1 commit into from
Jan 20, 2023
Merged

replace .at(-1) with array.length-1 #3080

merged 1 commit into from
Jan 20, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Jan 20, 2023 •
edited by github-actions bot
Loading

Follow up of matrix-org/matrix-react-sdk#9933

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Fix backwards compability for environment not support Array.prototype.at

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Fix backwards compability for environment not support Array.prototype.at (#3080).

@germain-gg germain-gg added T-Defect X-Release-Blocker backport staging Label to automatically backport PR to staging branch labels Jan 20, 2023
@germain-gg germain-gg requested a review from a team as a code owner January 20, 2023 11:12
@andybalaam andybalaam merged commit baeb4ac into develop Jan 20, 2023
@andybalaam andybalaam deleted the gsouquet/replace-at branch January 20, 2023 12:05
RiotRobot pushed a commit that referenced this pull request Jan 20, 2023
@github-actions
replace .at(-1) with array.length-1 (#3080)
b35ae1e 
(cherry picked from commit baeb4ac)
@RiotRobot RiotRobot mentioned this pull request Jan 20, 2023
Merged
andybalaam pushed a commit that referenced this pull request Jan 20, 2023
@RiotRobot
replace .at(-1) with array.length-1 (#3080) (#3081)
cabe14d 
(cherry picked from commit baeb4ac)

Co-authored-by: Germain <germains@element.io>
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Jan 30, 2023
@su-ex
Merge tag 'v23.1.1' into sc
d89e210 
* Fix backwards compability for environment not support Array.prototype.at ([\matrix-org#3080](matrix-org#3080)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@t3chguy t3chguy t3chguy approved these changes

@florianduros florianduros florianduros approved these changes

Assignees
No one assigned
Labels
backport staging Label to automatically backport PR to staging branch T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@germain-gg @andybalaam @t3chguy @florianduros