Support to remotely toggle push notifications #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germain-gg
force-pushed
the
gsouquet/msc3881-psg707
branch
from
37971d4
to
54b9d01
Compare
weeman1337
approved these changes
Sep 22, 2022
kerryarchibald
approved these changes
Sep 22, 2022
| @@ -156,9 +156,13 @@ export interface IPusher { | |||
| lang: string; | |||
| profile_tag?: string; | |||
| pushkey: string; | |||
| enabled?: boolean | null | undefined; | |||
There was a problem hiding this comment.
Should we add an unstable value constant for these fields?
There was a problem hiding this comment.
I don't think you can have dynamic names in interfaces like this? Or at least that wasn't possible when I tried
SimonBrandner
added a commit
that referenced
this pull request
Sep 22, 2022
* Update sonarcloud.yml (#2671) * Update sonarcloud.yml * test typescriptification - spec/unit/crypto/verification (#2673) * renamed: spec/unit/crypto/verification/request.spec.js -> spec/unit/crypto/verification/request.spec.ts * renamed: spec/unit/crypto/verification/qr_code.spec.js -> spec/unit/crypto/verification/qr_code.spec.ts * renamed: spec/unit/crypto/verification/InRoomChannel.spec.js -> spec/unit/crypto/verification/InRoomChannel.spec.ts * fix ts issues in InRoomChannel.spec * renamed: spec/unit/crypto/verification/util.js -> spec/unit/crypto/verification/util.ts * fix ts issues in util.t * fix strict errors in util.ts * js lint * test typescriptification - last few unit test files (#2675) * renamed: spec/unit/crypto/verification/sas.spec.js -> spec/unit/crypto/verification/sas.spec.ts * ts issues in sas.spec * renamed: spec/unit/crypto/verification/secret_request.spec.js -> spec/unit/crypto/verification/secret_request.spec.ts * ts issues in secret_request.spec * renamed: spec/unit/crypto/verification/verification_request.spec.js -> spec/unit/crypto/verification/verification_request.spec.ts * ts fix verification_req.spec * renamed: spec/browserify/sync-browserify.spec.js -> spec/browserify/sync-browserify.spec.ts * fix strict * formatting * Update babel monorepo to v7.19.1 (#2681) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update typescript-eslint monorepo to v5.38.0 (#2685) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Read receipts for threads (#2635) * Update all (#2684) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update jest monorepo to v29.0.3 (#2682) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix backpagination at end logic being spec non-conforming (#2680) * Support to remotely toggle push notifications (#2686) * Add unstable device_id field for MSC3881 (#2688) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Kerry <kerrya@element.io> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Germain <germains@element.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements MSC3881, matrix-org/matrix-spec-proposals#3881
Epic https://element-io.atlassian.net/browse/PSG-595
Fixes partially https://element-io.atlassian.net/browse/PSG-707
Checklist
Here's what your changelog entry will look like:
✨ Features