Don't remove streams that still have tracks #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a renogotiation ends up with one track being removed, we removed the whole stream, which would cause us to lose, for example, audio rather than just video.
SimonBrandner
approved these changes
Jan 13, 2022
turt2live
approved these changes
Jan 14, 2022
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Jan 31, 2022
* Support m.asset in m.location event content ([\matrix-org#2109](matrix-org#2109)). * Send extensible events structure and support on-demand parsing ([\matrix-org#2091](matrix-org#2091)). * Support cancelling events whilst they are in status = ENCRYPTING ([\matrix-org#2095](matrix-org#2095)). * Fix http-api butchering idServer requests ([\matrix-org#2134](matrix-org#2134)). Fixes element-hq/element-web#20680. * Don't remove streams that still have tracks ([\matrix-org#2104](matrix-org#2104)).
robertlong
pushed a commit
that referenced
this pull request
Mar 1, 2022
If a renogotiation ends up with one track being removed, we removed the whole stream, which would cause us to lose, for example, audio rather than just video.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a renogotiation ends up with one track being removed, we removed
the whole stream, which would cause us to lose, for example, audio
rather than just video.
Here's what your changelog entry will look like:
🐛 Bug Fixes