Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createClient should set up sessionStore #863

Open
jryans opened this issue Mar 20, 2019 · 2 comments
Open

createClient should set up sessionStore #863

jryans opened this issue Mar 20, 2019 · 2 comments
Labels
Help Wanted Extra attention is needed T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Mar 20, 2019 •
edited
Loading

Currently the JS SDK requires both sessionStore and cryptoStore for E2E to work properly, but the createClient helper only creates 1 out of 2, leading to various confused reports as to why E2E doesn't work.
@turt2live turt2live added T-Defect Help Wanted Extra attention is needed labels Mar 20, 2019
@cedricvanrompay
Copy link
Contributor

It seems that this was in the roadmap at least at some point,
according to documentation of MatrixClient:

The createClient helper will not create this store at the moment.

source:

matrix-js-sdk/src/client.js

Line 117 in 6979177

* end-to-end crypto will be disabled. The `createClient` helper

@jryans
Copy link
Collaborator Author

jryans commented Apr 25, 2019

Ah, I added that comment last month when I was surprised by it not happening by default. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Extra attention is needed T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @turt2live @cedricvanrompay